Re: Fix incorrect function reference BufFileOpenShared in comment.

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: Zhang Mingli <zmlpostgres@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-03T07:41:38Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix incorrect function reference in comment
- 605bfb7dbe5d 19 (unreleased) landed
Refactor sharedfileset.c to separate out fileset implementation.
- dcac5e7ac157 15.0 cited

On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> > The comment incorrectly cited the defunct function BufFileOpenShared()
> > which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
> >
> > Update the reference to the current function: BufFileOpenFileSet().

> Nice catch.  Running `git grep 'BufFile.*Shared'` confirms that this
> is the only place referencing the outdated BufFileXXXShared()
> functions.  I'll push this patch barring any objections.

Pushed.

- Richard