Thread

Commits

  1. Fix another typo in e0b1ee17dc

  1. Fix a typo in _bt_readpage

    Richard Guo <guofenglinux@gmail.com> — 2023-10-07T11:02:09Z

    I just noticed that e8c334c47a fixes typos in e0b1ee17dc.  I think there
    is an omission in _bt_readpage.
    
    --- a/src/backend/access/nbtree/nbtsearch.c
    +++ b/src/backend/access/nbtree/nbtsearch.c
    @@ -1784,7 +1784,7 @@ _bt_readpage(IndexScanDesc scan, ScanDirection dir,
    OffsetNumber offnum)
                /*
                 * If the result of prechecking required keys was true, then in
                 * assert-enabled builds we also recheck that _bt_checkkeys()
    -            * result is is the same.
    +            * result is the same.
                 */
                Assert(!requiredMatchedByPrecheck ||
                       passes_quals == _bt_checkkeys(scan, itup, indnatts, dir,
    
    Thanks
    Richard
    
  2. Re: Fix a typo in _bt_readpage

    Alexander Korotkov <aekorotkov@gmail.com> — 2023-10-07T17:38:54Z

    On Sat, Oct 7, 2023 at 2:02 PM Richard Guo <guofenglinux@gmail.com> wrote:
    >
    > I just noticed that e8c334c47a fixes typos in e0b1ee17dc.  I think there
    > is an omission in _bt_readpage.
    >
    > --- a/src/backend/access/nbtree/nbtsearch.c
    > +++ b/src/backend/access/nbtree/nbtsearch.c
    > @@ -1784,7 +1784,7 @@ _bt_readpage(IndexScanDesc scan, ScanDirection dir, OffsetNumber offnum)
    >             /*
    >              * If the result of prechecking required keys was true, then in
    >              * assert-enabled builds we also recheck that _bt_checkkeys()
    > -            * result is is the same.
    > +            * result is the same.
    >              */
    >             Assert(!requiredMatchedByPrecheck ||
    >                    passes_quals == _bt_checkkeys(scan, itup, indnatts, dir,
    
    Fixed, thanks!
    
    ------
    Regards,
    Alexander Korotkov