Horton

Re: Crash after a call to pg_backup_start()

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-10-21T09:53:25Z
Lists: pgsql-hackers 
On Fri, Oct 21, 2022 at 3:10 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

> It seems to me that the comment is true and the condition is a thinko.


Yeah, the two conditions could be both false. How about we update the
comment a bit to emphasize this? Such as

    /* At most one of these conditions can be true */
or
    /* These conditions can not be both true */


> Please find the attached fix.


+1

Thanks
Richard

Commits

  1. Fix recently added incorrect assertion