Horton

Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, zuming.jiang@inf.ethz.ch, pgsql-bugs@lists.postgresql.org, PG Bug reporting form <noreply@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-11-22T08:59:21Z
Lists: pgsql-bugs 
On Wed, Nov 22, 2023 at 10:32 AM Andrei Lepikhov <a.lepikhov@postgrespro.ru>
wrote:

> Your patch is ok.


Thanks for looking into this patch.


> I think the comment, 'PHVs should not impose ...' looks redundant. It
> may be enough to have it in the commit comment.


Hmm, I'm not sure.  I'm thinking that when people read this part of the
code, they might be confused as to why we don't consider PHVs.  And this
comment will give them some clues.  This is just like how we explain why
we need not worry about LATERAL nor PHVs in is_simple_values().

Thanks
Richard

Commits

  1. Fix a comment for remove_self_joins_recurse()

  2. Don't constrain self-join removal due to PHVs

  3. Handle PlaceHolderVar case in replace_varno_walker

  4. Fix how SJE checks against PHVs

  5. citext: Allow tests to pass in OpenSSL FIPS mode