Horton

Re: Fix shadow warnings in logical replication code

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-08-30T01:50:17Z
Lists: pgsql-hackers 
On Wed, Aug 30, 2023 at 8:49 AM Michael Paquier <michael@paquier.xyz> wrote:

> There is much more going on with -Wshadow, but let's do things
> incrementally, case by case.


Yeah, IIRC the source tree currently is able to be built without any
shadow-related warnings with -Wshadow=compatible-local.  But with
-Wshadow or -Wshadow=local, you can still see a lot of warnings.

Thanks
Richard

Commits

  1. Fix some shadow variables in src/backend/replication/