Re: Wrong results due to missing quals

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-05-25T06:36:31Z
Lists: pgsql-hackers
On Thu, May 25, 2023 at 5:28 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I tried this and it seems to work all right: it fixes the example
> you showed while not causing any new failures.  (Doesn't address
> the broken join-removal logic you showed in the other thread,
> though.)
>
> While at it, I also changed make_restrictinfo to treat has_clone
> and is_clone as first-class citizens, to fix the dubious coding in
> equivclass.c that I mentioned at [1].


The "incompatible_relids" idea is a stroke of genius.  I reviewed the
patch and did not find any problem.  So big +1 to the patch.

Thanks
Richard

Commits

  1. Fix filtering of "cloned" outer-join quals some more.