Re: BUG #18902: TRAP:: failed Assert("!is_sorted") in File: "createplan.c"

On Sat, May 3, 2025 at 10:50 AM Tender Wang <tndrwang@gmail.com> wrote:
> Richard Guo <guofenglinux@gmail.com> 于2025年5月2日周五 15:03写道：
>> Fair point.  Here is the patchset doing that.  0001 fixes this bug by
>> setting outersortkeys/innersortkeys to NIL in GetExistingLocalJoinPath
>> if we detect that the new outer/inner path of the MergePath is already
>> sorted properly.

> The 0001 fixing this bug looks good to me.

I've pushed this fix to master.  I'm not quite sure whether it should
be backpatched.  In the back branches, the issue leads to the addition
of a redundant Sort node in the plan that is only used for EPQ checks.
Since usually the efficiency of the EPQ plan is not a concern, this
doesn't seem like a big issue.  Besides, this issue has existed in
back branches for a long time but we haven't received any field
reports.

That said, if anyone thinks there's a good reason to backpatch it, I'm
happy to do so.

Thanks
Richard