Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-04-12T09:11:25Z
Lists: pgsql-hackers
On Fri, Apr 12, 2024 at 4:19 PM David Rowley <dgrowleyml@gmail.com> wrote:

> After further work on the comments, I pushed the result.
>
> Thanks for working on this.


Thanks for pushing!

BTW, I noticed a typo in the comment of add_base_clause_to_rel.

--- a/src/backend/optimizer/plan/initsplan.c
+++ b/src/backend/optimizer/plan/initsplan.c
@@ -2644,7 +2644,7 @@ add_base_clause_to_rel(PlannerInfo *root, Index relid,
     * apply_child_basequals() sees, whereas the inh==false one is what's
used
     * for the scan node in the final plan.
     *
-    * We make an exception to this is for partitioned tables.  For these,
we
+    * We make an exception to this for partitioned tables.  For these, we

Thanks
Richard

Commits

  1. Fix recently introduced typo in code comment

  2. Fix IS [NOT] NULL qual optimization for inheritance tables