Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Richard Guo <guofenglinux@gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, 邱宇航 <iamqyh@gmail.com>, Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-10-21T03:58:53Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix test case from 40c242830
- ee49f2cf447a 18.1 landed
-
Fix pushdown of degenerate HAVING clauses
- 40c2428307b8 18.1 landed
- 18d261409348 19 (unreleased) landed
-
Allow pushdown of HAVING clauses with grouping sets
- 67a54b9e83d3 18.0 cited
-
Mark expressions nullable by grouping sets
- f5050f795aea 18.0 cited
On Tue, Oct 21, 2025 at 12:26 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > Richard Guo <guofenglinux@gmail.com> writes: > > Regarding the tests, I think we could add another test query to cover > > the case with no empty grouping sets and degenerate HAVING clauses. > > This way, all cases for the HAVING pushdown optimization with grouping > > sets should be covered. > > > I've added such a test in v5, along with a commit message. Nothing > > else has changed. I'll push this patch soon, barring any objections. > v5 LGTM. Cool! I've pushed and back-patched v5. Thanks for working on this patch. 邱宇航, thanks for the report -- it's a good one. This issue should be fixed in 18.1, which is scheduled for release in November (the 13th, I believe). - Richard