Re: Eager aggregation, take 3

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es

From: Richard Guo <guofenglinux@gmail.com>

To: Andy Fan <zhihuifan1213@163.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, pgsql-hackers@lists.postgresql.org

Date: 2024-03-05T11:19:41Z

Lists: pgsql-hackers

Attachments

v3-0001-Introduce-RelInfoList-structure.patch (application/octet-stream) patch v3-0001
v3-0002-Introduce-RelAggInfo-structure-to-store-info-for-grouped-paths.patch (application/octet-stream) patch v3-0002
v3-0003-Set-up-for-eager-aggregation-by-collecting-needed-infos.patch (application/octet-stream) patch v3-0003
v3-0004-Implement-functions-that-create-RelAggInfos-if-applicable.patch (application/octet-stream) patch v3-0004
v3-0005-Implement-functions-that-generate-paths-for-grouped-relations.patch (application/octet-stream) patch v3-0005
v3-0006-Build-grouped-relations-out-of-base-relations.patch (application/octet-stream) patch v3-0006
v3-0007-Build-grouped-relations-out-of-join-relations.patch (application/octet-stream) patch v3-0007
v3-0008-Add-test-cases.patch (application/octet-stream) patch v3-0008
v3-0009-Add-README.patch (application/octet-stream) patch v3-0009

On Tue, Mar 5, 2024 at 2:47 PM Richard Guo <guofenglinux@gmail.com> wrote:

> This needs a rebase after dbbca2cf29.  I also revised the commit message
> for 0007 and fixed a typo in 0009.
>

Here is another rebase, mainly to make the test cases more stable by
adding ORDER BY clauses to the test queries.  Also fixed more typos in
passing.

Thanks
Richard

Commits

Fix eager aggregation for semi/antijoin inner rels
- ffeda04259bb 19 (unreleased) landed
Cover additional errors and corner conditions in repack.c
- 2670cc298f42 19 (unreleased) cited
Fix volatile function evaluation in eager aggregation
- 3a08a2a8b4fd 19 (unreleased) landed
Fix collation handling for grouping keys in eager aggregation
- bd94845e8c90 19 (unreleased) landed
Rename apply_at to apply_agg_at for clarity
- 1206df04c200 19 (unreleased) landed
Fix comment in eager_aggregate.sql
- 36fd8bde1b77 19 (unreleased) landed
Remove unnecessary include of "utils/fmgroids.h"
- f997d777adf7 19 (unreleased) landed
Implement Eager Aggregation
- 8e11859102f9 19 (unreleased) landed
Allow negative aggtransspace to indicate unbounded state size
- 185e30426334 19 (unreleased) landed
Add macros for looping through a List without a ListCell.
- 14dd0f27d7cd 17.0 cited
Account for the effect of lossy pages when costing bitmap scans.
- 5edc63bda68a 11.0 cited
Fix a thinko in join_is_legal: when we decide we can implement a semijoin
- a43b190e3c71 9.0.0 cited