Horton

Re: Correction of RowMark Removal During Sel-Join Elimination

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrei Lepikhov <lepihov@gmail.com>, Greg Sabino Mullane <htamfids@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alexander Lakhin <exclusion@gmail.com>
Date: 2025-08-30T23:51:24Z
Lists: pgsql-hackers 
On Sun, Aug 31, 2025 at 8:41 AM Richard Guo <guofenglinux@gmail.com> wrote:
> On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > The same patch with a bit revised comment and commit message.

> FWIW, I reported this same issue and proposed the patch last week in
> Discussion: https://postgr.es/m/CAMbWs48x=GsGan_bvQ+j0rLqYFNi9W725EmJpWUZv1RrmaicZQ@mail.gmail.com

I think it's better to push this patch sooner rather than later, as
multiple people have encountered the issue in different ways.  I'll go
ahead and push 0001 from my patch set shortly.  I don't think we need
to backpatch it, since the issue only occurs after commit e2debb643.

Thanks
Richard

Commits

  1. Improve RowMark handling during Self-Join Elimination

  2. Refactor variable names in remove_self_joins_one_group()

  3. Reduce "Var IS [NOT] NULL" quals during constant folding

  4. Reimplement parsing and storage of default expressions and constraint