Horton

Re: Issue with query_is_distinct_for() and grouping sets

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-23T07:07:05Z
Lists: pgsql-hackers

Attachments

On Thu, Oct 23, 2025 at 1:33 PM David Rowley <dgrowleyml@gmail.com> wrote:
> On Thu, 23 Oct 2025 at 16:43, Richard Guo <guofenglinux@gmail.com> wrote:
> > How about using the following wording in the commit message?
> >
> > "
> > The previous logic in query_is_distinct_for() was incomplete because
> > the check was insufficiently thorough and could return false when it
> > should have returned true.
> > "

> "it could" might be more accurate. The function is under no obligation
> to return true for every possible case.

Fair point.  Patch updated with a revised commit message.

- Richard

Commits

  1. Fix distinctness check for queries with grouping sets