Re: duplicated comments on get_relation_constraints
Richard Guo <guofenglinux@gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-02T02:39:38Z
Lists: pgsql-hackers
On Sat, Mar 29, 2025 at 1:38 AM Kirill Reshke <reshkekirill@gmail.com> wrote: > On Fri, 28 Mar 2025 at 15:19, Richard Guo <guofenglinux@gmail.com> wrote: > > On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke <reshkekirill@gmail.com> wrote: > > > On Fri, 28 Mar 2025 at 09:47, jian he <jian.universality@gmail.com> wrote: > > > > The first "Also ignore if NO INHERIT and we weren't told that that's > > > > safe." is duplicated, > > > > also it's in the wrong place? > > > > The second one is fine. > > > Hi! Indeed. Looks like an oversight from ca87c41. I think we can > > > safely remove one of those, presumably the first one. > > +1. Also there is an extra blank line after the NO INHERIT check. I > > think we can remove it while we're here. > Sure. PFA attached, if needed The change looks good to me. I plan to push it soon, barring any objections. Thanks Richard
Commits
-
Remove duplicated comment in get_relation_constraints
- ea5d3f52334a 18.0 landed