Re: Assert failure on bms_equal(child_joinrel->relids, child_joinrelids)

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-07-24T02:47:00Z
Lists: pgsql-hackers
On Sat, Jul 22, 2023 at 12:02 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Richard Guo <guofenglinux@gmail.com> writes:
> > Instead of fixing add_outer_joins_to_relids() to cope with child joins,
> > I'm wondering if we can build join relids for a child join from its
> > parent by adjust_child_relids, something like attached.
>
> That looks like a good solid solution.  Pushed with a bit of
> editorialization --- mostly, that I put the test case into
> partition_join.sql where there's already suitable test tables.


Thanks for pushing it!

Thanks
Richard

Commits

  1. Reduce memory used by partitionwise joins

  2. Fix calculation of relid sets for partitionwise child joins.