Re: BUG #17606: There is still some glitch in 3f7323cbb fixing failure of MULTIEXPR_SUBLINK

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>
To: 857348270@qq.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-09-05T14:25:15Z
Lists: pgsql-bugs
On Mon, Sep 5, 2022 at 3:33 PM PG Bug reporting form <noreply@postgresql.org>
wrote:

> 3f7323cbb regenerates its Param for each SubPlan by traversing the
> targetlist. But ignore one point: initplan is not in targetlist.
> This will result in a failed assertion, or an error like "unexpected
> PARAM_MULTIEXPR ID: 131074"


Since initplan SubPlans do not have args lists, I think it's OK for them
to share output parameters. So maybe we do not need to do the
SS_make_multiexprs_unique trick for initplan SubPlans?

Thanks
Richard

Commits

  1. Further fixes for MULTIEXPR_SUBLINK fix.