Horton

Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, zuming.jiang@inf.ethz.ch, pgsql-bugs@lists.postgresql.org, PG Bug reporting form <noreply@postgresql.org>
Date: 2023-12-12T06:41:13Z
Lists: pgsql-bugs 
On Thu, Dec 7, 2023 at 10:55 AM Andrei Lepikhov <a.lepikhov@postgrespro.ru>
wrote:

> According to the patches:
> 0001 - looks good for me.
> 0002 - I don't understand why to use 'explain' in VERBOSE mode in tests.
> What do you try to detect here?


The VERBOSE mode is used to observe that PHVs are adjusted correctly and
put in the right targetlist.


> 0003 - ok, but too short. Maybe squash all these patches into one?


It seems to me that these three patches are addressing separate issues
and are independent of each other.  For instance, the issue addressed by
0001 exists on master even without other changes, and 0002 is an
improvement that does not depend on others, while 0003 is a fix of an
incorrect comment.  I don't think it's a good idea to squash them into
one.


> I think these corrections are good enough for commit.


Thank you for reviewing these patches.  Alexander, what are your
thoughts on these patches?

Thanks
Richard

Commits

  1. Fix a comment for remove_self_joins_recurse()

  2. Don't constrain self-join removal due to PHVs

  3. Handle PlaceHolderVar case in replace_varno_walker

  4. Fix how SJE checks against PHVs

  5. citext: Allow tests to pass in OpenSSL FIPS mode