Re: Eager aggregation, take 3

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es

From: Richard Guo <guofenglinux@gmail.com>

To: Andy Fan <zhihuifan1213@163.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, pgsql-hackers@lists.postgresql.org

Date: 2024-03-05T06:47:27Z

Lists: pgsql-hackers

Attachments

v2-0001-Introduce-RelInfoList-structure.patch (application/octet-stream) patch v2-0001
v2-0004-Implement-functions-that-create-RelAggInfos-if-applicable.patch (application/octet-stream) patch v2-0004
v2-0002-Introduce-RelAggInfo-structure-to-store-info-for-grouped-paths.patch (application/octet-stream) patch v2-0002
v2-0005-Implement-functions-that-generate-paths-for-grouped-relations.patch (application/octet-stream) patch v2-0005
v2-0003-Set-up-for-eager-aggregation-by-collecting-needed-infos.patch (application/octet-stream) patch v2-0003
v2-0006-Build-grouped-relations-out-of-base-relations.patch (application/octet-stream) patch v2-0006
v2-0009-Add-README.patch (application/octet-stream) patch v2-0009
v2-0007-Build-grouped-relations-out-of-join-relations.patch (application/octet-stream) patch v2-0007
v2-0008-Add-test-cases.patch (application/octet-stream) patch v2-0008

On Mon, Mar 4, 2024 at 7:49 PM Andy Fan <zhihuifan1213@163.com> wrote:

> This is a really helpful and not easy task, even I am not sure when I
> can spend time to study this, I want to say "Thanks for working on
> this!" first and hope we can really progress on this topic. Good luck!

Thanks.  I hope this take can go even further and ultimately find its
way to be committed.

This needs a rebase after dbbca2cf29.  I also revised the commit message
for 0007 and fixed a typo in 0009.

Thanks
Richard

Commits

Fix eager aggregation for semi/antijoin inner rels
- ffeda04259bb 19 (unreleased) landed
Cover additional errors and corner conditions in repack.c
- 2670cc298f42 19 (unreleased) cited
Fix volatile function evaluation in eager aggregation
- 3a08a2a8b4fd 19 (unreleased) landed
Fix collation handling for grouping keys in eager aggregation
- bd94845e8c90 19 (unreleased) landed
Rename apply_at to apply_agg_at for clarity
- 1206df04c200 19 (unreleased) landed
Fix comment in eager_aggregate.sql
- 36fd8bde1b77 19 (unreleased) landed
Remove unnecessary include of "utils/fmgroids.h"
- f997d777adf7 19 (unreleased) landed
Implement Eager Aggregation
- 8e11859102f9 19 (unreleased) landed
Allow negative aggtransspace to indicate unbounded state size
- 185e30426334 19 (unreleased) landed
Add macros for looping through a List without a ListCell.
- 14dd0f27d7cd 17.0 cited
Account for the effect of lossy pages when costing bitmap scans.
- 5edc63bda68a 11.0 cited
Fix a thinko in join_is_legal: when we decide we can implement a semijoin
- a43b190e3c71 9.0.0 cited