Thread

Re: Fix comments for ChangeVarNodes() and related functions

Richard Guo <guofenglinux@gmail.com> — 2025-11-05T03:47:37Z

On Mon, Nov 3, 2025 at 9:14 PM Peter Eisentraut <peter@eisentraut.org> wrote:
> On 23.10.25 10:59, Richard Guo wrote:
> > I happend to notice this comment for ChangeVarNodes():
> >
> >   * Specifying 'change_RangeTblRef' to false allows skipping RangeTblRef.
> >   * See ChangeVarNodesExtended for details.
> >
> > However, I couldn't find "change_RangeTblRef" anywhere in the code
> > base.  I suspect this is a leftover from development.  In any case, I
> > think we should fix it.

> It appears that change_RangeTblRef was removed in commit ab42d643c14 but
> the comments were not fully adjusted.

Right.  I've pushed this patch and backpatched it to v18.  However,
this only covers ChangeVarNodes().  We still need a separate patch to
fix remove_rel_from_query().

- Richard