Re: Wrong results with grouping sets

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2024-10-25T01:09:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove the RTE_GROUP RTE if we drop the groupClause
- ffe12d1d22e7 18.0 landed
Mark expressions nullable by grouping sets
- f5050f795aea 18.0 landed
Introduce an RTE for the grouping step
- 247dea89f761 18.0 landed

On Thu, Oct 10, 2024 at 6:51 PM Richard Guo <guofenglinux@gmail.com> wrote:
> On Thu, Oct 10, 2024 at 4:06 PM Richard Guo <guofenglinux@gmail.com> wrote:
> > While we can fix this issue by propagating the hasGroupRTE mark from
> > the EXISTS subquery to the parent, a better fix might be to remove the
> > subquery's RTE_GROUP entry, since we have dropped the subquery's
> > groupClause before the pull-up (see simplify_EXISTS_query).
>
> Here is the patch.

I've pushed this patch with minor tweaks.  Thanks again for the
report!

Thanks
Richard