Horton

Re: Eager aggregation, take 3

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>, Paul George <p.a.george19@gmail.com>, Andy Fan <zhihuifan1213@163.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, pgsql-hackers@lists.postgresql.org
Date: 2025-01-13T02:04:34Z
Lists: pgsql-hackers

Attachments

On Sat, Dec 21, 2024 at 10:05 AM Richard Guo <guofenglinux@gmail.com> wrote:
> Attached is the latest patch, which also includes some cosmetic
> tweaks.  I am seeking the possibility of pushing this by the end of
> January, so that I can have enough time to react to any bugs before
> the feature freeze.

Attached is an updated version of this patch that addresses Jian's
review comments, along with some more cosmetic tweaks.  I'm going to
be looking at this patch again from the point of view of committing
it, with the plan to commit it late this week or early next week,
barring any further comments or objections.

Thanks
Richard

Commits

  1. Fix eager aggregation for semi/antijoin inner rels

  2. Cover additional errors and corner conditions in repack.c

  3. Fix volatile function evaluation in eager aggregation

  4. Fix collation handling for grouping keys in eager aggregation

  5. Rename apply_at to apply_agg_at for clarity

  6. Fix comment in eager_aggregate.sql

  7. Remove unnecessary include of "utils/fmgroids.h"

  8. Implement Eager Aggregation

  9. Allow negative aggtransspace to indicate unbounded state size

  10. Add macros for looping through a List without a ListCell.

  11. Account for the effect of lossy pages when costing bitmap scans.

  12. Fix a thinko in join_is_legal: when we decide we can implement a semijoin