Re: Check lateral references within PHVs for memoize cache keys

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2022-12-30T03:00:25Z

Lists: pgsql-hackers

Attachments

v2-0001-Check-lateral-refs-within-PHVs-for-memoize-cache-.patch (application/octet-stream) patch v2-0001

On Fri, Dec 9, 2022 at 5:16 PM Richard Guo <guofenglinux@gmail.com> wrote:

> Actually we do have checked PHVs for lateral references, earlier in
> create_lateral_join_info.  But that time we only marked lateral_relids
> and direct_lateral_relids, without remembering the lateral expressions.
> So I'm wondering whether we can fix that by fetching Vars (or PHVs) of
> lateral references within PlaceHolderVars and remembering them in the
> baserel's lateral_vars.
>
> Attach a draft patch to show my thoughts.
>

Update the patch to fix test failures.

Thanks
Richard

Commits

Check lateral references within PHVs for memoize cache keys
- 069d0ff0226b 18.0 landed
Doc: update old reference to "result cache"
- 571377dfb83d 14.9 landed
- 3883ef3236e5 15.4 landed
- 6d8b5f49f0e1 16.0 landed
- c23e7ea4d6a4 17.0 landed