Horton

Re: A structure has changed but comment modifications maybe missed

Richard Guo <guofenglinux@gmail.com>

View thread
From: Richard Guo <guofenglinux@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, 甄明洋 <zhenmingyang@yeah.net>, pgsql-bugs@postgresql.org
Date: 2023-03-30T03:33:43Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix outdated comments regarding TupleTableSlots

On Thu, Mar 30, 2023 at 11:07 AM Andres Freund <andres@anarazel.de> wrote:

> On 2023-03-30 16:00:23 +1300, David Rowley wrote:
> > See the adjusted patch attached.
>
> Looks reasonable to me. We could try to reference TTS_SHOULDFREE(), without
> mentioning flags, instead - but I think your version is better.


+1.

Thanks
Richard