Horton

Re: BUG #18170: Unexpected error: no relation entry for relid 3

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Korotkov <aekorotkov@gmail.com>, Vik Fearing <vik@postgresfriends.org>, zuming.jiang@inf.ethz.ch, pgsql-bugs@lists.postgresql.org, Alexander Korotkov <akorotkov@postgresql.org>
Date: 2023-10-30T06:24:01Z
Lists: pgsql-bugs 
On Mon, Oct 30, 2023 at 10:47 AM Andrei Lepikhov <a.lepikhov@postgrespro.ru>
wrote:

> On 30/10/2023 09:24, Richard Guo wrote:
> > I also have some concerns about this patch.  It requires that
> > root->parse remains unchanged during the whole subquery_planner() in
> > order to work, which is an implicit constraint we did not have before.
>
> It is not about unchanged; it is about referencing the same query at the
> parent and child query blocks. Am I missing something?


Yeah, that's what I meant.  We need to ensure that root->parse
references the same Query structure during the whole subquery_planner()
for this patch to work, which seems hacky, and error-prone for future
development.  If we really want to do so, at least we need to emphasize
this point in the comment of subquery_planner().

Thanks
Richard

Commits

  1. Disable run condition optimization for some WindowFuncs

  2. Fix allocation of UniqueRelInfo

  3. Make UniqueRelInfo a node

  4. Add "Add trailing commas to enum definitions" to .git-blame-ignore-revs

  5. Remove useless self-joins