Re: Remove no-op pull_var_clause flag

On Thu, Jan 22, 2026 at 3:27 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Pyhalov <a.pyhalov@postgrespro.ru> writes:
> > While merging PostgreSQL to our (Shardman) fork, I've noticed that it
> > uses the same pull_var_clause() flag as we do (coming from
> > https://www.postgresql.org/message-id/CAFjFpRc8ZoDm0%2Bzhx%2BMckwGyEqkOzWcpVqbvjaxwdGarZSNrmA%40mail.gmail.com).
> > I was a bit surprised, the patch hasn't landed to master. But flag
> > somehow slipped in (but only as no-op). The attached patch removes
> > useless flag.

> Right, done.

Ugh... I wonder how this happened, and whether this is the only
instance of private code sneaking into the PostgreSQL codebase.  I'm
also kind of concerned about the legal risk if this comes from a
project with a strict license.

Should we also remove this code from v18?

- Richard