Re: Virtual generated columns

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: jian he <jian.universality@gmail.com>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Zhang Mingli <zmlpostgres@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-02-24T09:20:51Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 landed
Additional tests for stored generated columns
- 41084409f635 18.0 landed
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
Small code simplification
- 7ff9afbbd1df 18.0 landed
Remove useless code
- e26d313bad92 18.0 landed
Remove useless initializations
- da2aeba8f533 18.0 landed
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited

Attachments

v8-0001-Expand-virtual-generated-columns-in-the-planner.patch (application/octet-stream) patch v8-0001
v8-0002-Eliminate-code-duplication-in-replace_rte_variables-callbacks.patch (application/octet-stream) patch v8-0002

On Mon, Feb 24, 2025 at 3:50 PM jian he <jian.universality@gmail.com> wrote:
> On Sat, Feb 22, 2025 at 11:12 PM Richard Guo <guofenglinux@gmail.com> wrote:
> > On Sat, Feb 22, 2025 at 11:55 PM Richard Guo <guofenglinux@gmail.com> wrote:
> > > Attached are the updated patches to fix all the mentioned issues.  I
> > > plan to push them early next week after staring at the code for a bit
> > > longer, barring any objections.
> >
> > Sign... I neglected to make the change in 0001 that a Var newnode
> > compares its varlevelsup with 0 when deciding to wrap it in a
> > ReturningExpr.  I made this change in 0002 though, so maybe we're good
> > here.  Still, I'll fix this later.
> >
> i also noticed this issue...
>
> some minor comments about v7.

Thanks for reviewing.

Here are the updated patches with revised comments and some tweaks to
the commit messages.  I plan to push them in one or two days.

Thanks
Richard