Re: A structure has changed but comment modifications maybe missed

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: 甄明洋 <zhenmingyang@yeah.net>

Cc: pgsql-bugs@postgresql.org

Date: 2023-03-27T02:05:55Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix outdated comments regarding TupleTableSlots
- 902ecd3bd4e7 16.0 landed

On Sat, Mar 25, 2023 at 10:43 PM 甄明洋 <zhenmingyang@yeah.net> wrote:

> Recently when I was reading the TupleTableSlot code, I noticed that the
> field "tts_tuple" mentioned in the comment has been removed in the higher
> version, but it still exists in the comment.
> location：
>
> https://github.com/postgres/postgres/blob/master/src/include/executor/tuptable.h
> src/include/executor/tuptable.h：71
> src/include/executor/tuptable.h：271
>

Good catch.  This should be a minor oversight in 4da597ed, in which the
TupleTableSlot implementation has been splitted into different slot
types, and tts_tuple has been removed from TupleTableSlot struct.

Besides, at tuptable.h:71, I think TTS_SHOULDFREE should be
TTS_FLAG_SHOULDFREE.

Thanks
Richard