Horton

Re: Eager aggregation, take 3

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Tender Wang <tndrwang@gmail.com>, Paul George <p.a.george19@gmail.com>, Andy Fan <zhihuifan1213@163.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, pgsql-hackers@lists.postgresql.org, Matheus Alcantara <matheusssilv97@gmail.com>
Date: 2025-10-09T07:01:28Z
Lists: pgsql-hackers 
On Thu, Oct 9, 2025 at 2:09 PM Antonin Houska <ah@cybertec.at> wrote:
> Richard Guo <guofenglinux@gmail.com> wrote:
> > I've pushed v24 -- thanks for all the reviews!  Now bracing for the
> > upcoming bug reports.

> Thanks for finishing this! The lack of feedback I encountered earlier made me
> so frustrated that I could not find motivation to collaborate with you. I'm
> happy now that my effort did not get wasted.

Your efforts in the earlier versions were very important for getting
this feature done.  Thank you for your work.

- Richard

Commits

  1. Fix eager aggregation for semi/antijoin inner rels

  2. Cover additional errors and corner conditions in repack.c

  3. Fix volatile function evaluation in eager aggregation

  4. Fix collation handling for grouping keys in eager aggregation

  5. Rename apply_at to apply_agg_at for clarity

  6. Fix comment in eager_aggregate.sql

  7. Remove unnecessary include of "utils/fmgroids.h"

  8. Implement Eager Aggregation

  9. Allow negative aggtransspace to indicate unbounded state size

  10. Add macros for looping through a List without a ListCell.

  11. Account for the effect of lossy pages when costing bitmap scans.

  12. Fix a thinko in join_is_legal: when we decide we can implement a semijoin