Horton

Re: Improve list manipulation in several places

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>, David Rowley <dgrowleyml@gmail.com>, Ranier Vilela <ranier.vf@gmail.com>
Date: 2023-07-04T00:48:00Z
Lists: pgsql-hackers 
On Mon, Jul 3, 2023 at 5:41 PM Peter Eisentraut <
peter.eisentraut@enterprisedb.com> wrote:

> On 09.05.23 05:13, Richard Guo wrote:
> > Yeah, maybe this is the reason I failed to devise a query that shows any
> > performance gain.  I tried with a query which makes the 'all_pathkeys'
> > in sort_inner_and_outer being length of 500 and still cannot see any
> > notable performance improvements gained by list_copy_move_nth_to_head.
> > Maybe the cost of other parts of planning swamps the performance gain
> > here?  Now I agree that maybe 0002 is not worthwhile to do.
>
> I have committed patch 0001.  Since you have withdrawn 0002, this closes
> the commit fest item.


Thanks for pushing it and closing the item!

Thanks
Richard

Commits

  1. A minor simplification for List manipulation