Horton
Menu

Re: postgres_fdw: wrong results with self join + enable_nestloop off

Richard Guo <guofenglinux@gmail.com>

View thread
From: Richard Guo <guofenglinux@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Nishant Sharma <nishant.sharma@enterprisedb.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2023-06-06T03:20:26Z
Lists: pgsql-hackers 
On Mon, Jun 5, 2023 at 9:19 PM Etsuro Fujita <etsuro.fujita@gmail.com>
wrote:

> If the patch is intended for HEAD only, I also think it goes in the
> right direction.  But if it is intended for back branches as well, I
> do not think so, because it would cause ABI breakage due to changes
> made to the ForeignPath struct and the create_foreign_join_path() API.
> (For the former, I think we could avoid doing so by adding the new
> member at the end of the struct, not in the middle, though.)


Thanks for pointing this out.  You're right.  The patch has backport
issue because of the ABI breakage.  So it can only be applied on HEAD.


> To avoid this issue, I am wondering if we should modify
> add_paths_to_joinrel() in back branches so that it just disallows the
> FDW to consider pushing down joins when the restrictlist has
> pseudoconstant clauses.  Attached is a patch for that.


I think we can do that in back branches.  But I'm a little concerned
that we'd miss a better plan if FDW cannot push down joins in such
cases.  I may be worrying over nothing though if it's not common that
the restrictlist has pseudoconstant clauses.

Thanks
Richard

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Re-allow FDWs and custom scan providers to replace joins with pseudoconstant quals.

  2. Disallow replacing joins with scans in problematic cases.

  3. doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+