Horton

Thread

Commits

  1. Fix make maintainer-clean with queryjumblefuncs.*.c files in src/backend/nodes/

  1. Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Michael Paquier <michael@paquier.xyz> — 2023-03-20T06:43:09Z

    Hi all,

Nathan has reported to me offlist that maintainer-clean was not doing
its job for the files generated by gen_node_support.pl in
src/backend/nodes/ for the query jumbling.  Attached is a patch to
take care of this issue.

While on it, I have found a comment in the related README that was
missing a refresh.

Any objections or comments?
--
Michael

  2. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Richard Guo <guofenglinux@gmail.com> — 2023-03-20T07:18:17Z

    On Mon, Mar 20, 2023 at 2:43 PM Michael Paquier <michael@paquier.xyz> wrote:

> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling.  Attached is a patch to
> take care of this issue.
>
> While on it, I have found a comment in the related README that was
> missing a refresh.
>
> Any objections or comments?


A minor comment for the README is that now we have five support
functions not four.

- outcome.  (For some classes of node types, you don't need all four support
+ outcome.  (For some classes of node types, you don't need all five support

Thanks
Richard

  3. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Michael Paquier <michael@paquier.xyz> — 2023-03-20T07:46:08Z

    On Mon, Mar 20, 2023 at 03:18:17PM +0800, Richard Guo wrote:
> A minor comment for the README is that now we have five support
> functions not four.
> 
> - outcome.  (For some classes of node types, you don't need all four support
> + outcome.  (For some classes of node types, you don't need all five support

Right, missed that.  How about removing the "fout/five" entirely here
and make that simpler?  I would propose:
"For some classes of node types, you don't need all the support
functions."
--
Michael

  4. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Daniel Gustafsson <daniel@yesql.se> — 2023-03-20T07:49:25Z

    > On 20 Mar 2023, at 08:46, Michael Paquier <michael@paquier.xyz> wrote:

> How about removing the "fout/five" entirely here
> and make that simpler?  I would propose:
> "For some classes of node types, you don't need all the support
> functions."

Yes please, keeping such counts in sync is always error-prone.

--
Daniel Gustafsson

  5. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Richard Guo <guofenglinux@gmail.com> — 2023-03-20T08:04:31Z

    On Mon, Mar 20, 2023 at 3:49 PM Daniel Gustafsson <daniel@yesql.se> wrote:

> > On 20 Mar 2023, at 08:46, Michael Paquier <michael@paquier.xyz> wrote:
> > How about removing the "fout/five" entirely here
> > and make that simpler?  I would propose:
> > "For some classes of node types, you don't need all the support
> > functions."
>
> Yes please, keeping such counts in sync is always error-prone.


Agreed. +1 to remove the counts.

Thanks
Richard

  6. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-03-20T14:21:28Z

    Michael Paquier <michael@paquier.xyz> writes:
> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling.  Attached is a patch to
> take care of this issue.
> While on it, I have found a comment in the related README that was
> missing a refresh.
> Any objections or comments?

Is similar knowledge missing in the meson build files?

			regards, tom lane

  7. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Michael Paquier <michael@paquier.xyz> — 2023-03-21T00:17:22Z

    On Mon, Mar 20, 2023 at 10:21:28AM -0400, Tom Lane wrote:
> Is similar knowledge missing in the meson build files?

src/backend/nodes/meson.build and src/include/nodes/meson.build are
the two meson files that have the knowledge about the files generated
by gen_node_support.pl, and the query jumbling files are consistent
with that since 0e681cf.  Perhaps I've missed an extra spot?
--
Michael

  8. Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

    Michael Paquier <michael@paquier.xyz> — 2023-03-21T23:42:42Z

    On Mon, Mar 20, 2023 at 04:04:31PM +0800, Richard Guo wrote:
> Agreed. +1 to remove the counts.

Thanks.  Adjusted this way, then.
--
Michael