Re: Wrong results with grouping sets

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2024-07-01T08:29:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove the RTE_GROUP RTE if we drop the groupClause
- ffe12d1d22e7 18.0 landed
Mark expressions nullable by grouping sets
- f5050f795aea 18.0 landed
Introduce an RTE for the grouping step
- 247dea89f761 18.0 landed

Attachments

v9-0001-Introduce-an-RTE-for-the-grouping-step.patch (application/octet-stream) patch v9-0001
v9-0002-Mark-expressions-nullable-by-grouping-sets.patch (application/octet-stream) patch v9-0002

On Mon, Jun 10, 2024 at 5:05 PM Richard Guo <guofenglinux@gmail.com> wrote:
> This patchset does not apply any more.  Here is a new rebase.

Here is an updated version of this patchset.  I've run pgindent for it,
and also tweaked the commit messages a bit.

In principle, 0001 can be backpatched to all supported versions to fix
the cases where there are subqueries in the grouping expressions; 0002
can be backpatched to 16 where we have the nullingrels stuff.  But both
patches seem to be quite invasive.  I'm not sure if we want to backpatch
them to stable branches.  Any thoughts about backpatching?

Thanks
Richard