Horton

Thread

Commits

  1. Remove obsolete SAMESIGN macro

  2. Provide overflow safe integer math inline functions.

  1. Remove obsolete SAMESIGN macro

    Richard Guo <guofenglinux@gmail.com> — 2026-02-19T08:40:08Z

    The SAMESIGN macro was historically used as a helper for manual
integer overflow checks.  However, since commit 4d6ad3125 introduced
overflow-aware integer operations, this manual sign-checking logic is
no longer necessary.

The macro remains defined in brin_minmax_multi.c and timestamp.c, but
is not used in either file.  Any objections to removing these
definitions to clean things up?

- Richard

  2. Re: Remove obsolete SAMESIGN macro

    Andreas Karlsson <andreas@proxel.se> — 2026-02-19T11:23:12Z

    On 2/19/26 9:40 AM, Richard Guo wrote:
> The macro remains defined in brin_minmax_multi.c and timestamp.c, but
> is not used in either file.  Any objections to removing these
> definitions to clean things up?

No, that is dead code only visible within those files so I do not think 
anyone would object.

-- 
Andreas Karlsson
Percona