A minor adjustment to get_cheapest_path_for_pathkeys

Richard Guo <guofenglinux@gmail.com>

From: Richard Guo <guofenglinux@gmail.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-04-11T07:19:41Z
Lists: pgsql-hackers

Attachments

The check for parallel_safe should be even cheaper than cost comparison
so I think it's better to do that first.  The attached patch does this
and also updates the comment to mention the requirement about being
parallel-safe.

Thanks
Richard

Commits

  1. Reorder tests in get_cheapest_path_for_pathkeys().

  2. Fix an assortment of improper usages of string functions