Horton

Re: pg_plan_advice: FOREIGN_JOIN advice generated for a single-relation foreign scan is not round-trip safe

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-07-03T03:36:09Z
Lists: pgsql-hackers 
On Fri, Jul 3, 2026 at 11:27 AM Richard Guo <guofenglinux@gmail.com> wrote:
> On Fri, Jul 3, 2026 at 5:20 AM Robert Haas <robertmhaas@gmail.com> wrote:
> > Done. I ended up making some changes to the test case as well,
> > basically to make it less likely that it could accidentally pass.

> Seems pgindent is needed for this commit.

I've just pushed a trivial patch for the pgindent fix.

- Richard

Commits

  1. pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single relation.