Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix missing word in nbtree/README.

  1. Typo in src/backend/access/nbtree/README?

    Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> — 2023-06-08T14:11:18Z

    Hi,

I am not a native English speaker, but shouldn't there be a "to" before "detect"?

These two additions make it possible detect a concurrent page split

Regards
Daniel

  2. Re: Typo in src/backend/access/nbtree/README?

    Gurjeet Singh <gurjeet@singh.im> — 2023-06-09T02:36:41Z

    On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
<daniel.westermann@dbi-services.com> wrote:
>
> ... shouldn't there be a "to" before "detect"?
>
> These two additions make it possible detect a concurrent page split

Agreed. Attached is a small patch that fixes this.

Thanks for the report!

Best regards,
Gurjeet
http://Gurje.et

  3. Re: Typo in src/backend/access/nbtree/README?

    Richard Guo <guofenglinux@gmail.com> — 2023-06-09T03:29:02Z

    On Fri, Jun 9, 2023 at 10:37 AM Gurjeet Singh <gurjeet@singh.im> wrote:

> On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
> <daniel.westermann@dbi-services.com> wrote:
> >
> > ... shouldn't there be a "to" before "detect"?
> >
> > These two additions make it possible detect a concurrent page split
>
> Agreed. Attached is a small patch that fixes this.


+1.  A little nitpick: the new line seems overly long compared to
adjacent lines, should we wrap it?

Thanks
Richard

  4. Re: Typo in src/backend/access/nbtree/README?

    Nathan Bossart <nathandbossart@gmail.com> — 2023-06-09T04:24:22Z

    On Fri, Jun 09, 2023 at 11:29:02AM +0800, Richard Guo wrote:
> On Fri, Jun 9, 2023 at 10:37 AM Gurjeet Singh <gurjeet@singh.im> wrote:
> 
>> On Thu, Jun 8, 2023 at 7:11 AM Daniel Westermann (DWE)
>> <daniel.westermann@dbi-services.com> wrote:
>> >
>> > ... shouldn't there be a "to" before "detect"?
>> >
>> > These two additions make it possible detect a concurrent page split
>>
>> Agreed. Attached is a small patch that fixes this.
> 
> 
> +1.  A little nitpick: the new line seems overly long compared to
> adjacent lines, should we wrap it?

Committed, thanks.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com