Re: SPI_connect, SPI_connect_ext return type

Stepan Neretin <sndcppg@gmail.com>

From: Stepan Neretin <sndcppg@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-08-10T14:45:01Z
Lists: pgsql-hackers
> >That would break a lot of code (much of it not under our control) to
> little purpose; it would also foreclose the option to return to using
> SPI_ERROR_CONNECT someday.
>

Agree, it makes sense.
The only question left is, is there any logic in why in some places its
return value of these functions is checked, and in some not? Can I add
checks everywhere?
Best Regards, Stepan Neretin.

Commits

  1. Don't bother checking the result of SPI_connect[_ext] anymore.