Horton

Re: SPI_connect, SPI_connect_ext return type

Stepan Neretin <sndcppg@gmail.com>

View thread View on postgr.es
From: Stepan Neretin <sndcppg@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@lists.postgresql.org
Date: 2024-09-08T06:35:00Z
Lists: pgsql-hackers 
> So if we tell extension authors they don't need to check the result, it's
unlikely
> that that will cause any new code they write to get used with PG
> versions where it would be wrong.
Yes, I concur.

> This combines portions of Stepan's
> two patches with some additional work (mostly, that he'd missed fixing
> any of contrib/).
Thank you for the feedback! I believe the patch looks satisfactory. Should
we await a review? The changes seem straightforward to me.

Commits

  1. Don't bother checking the result of SPI_connect[_ext] anymore.