Horton

Re: vacuumdb: permission denied for schema "pg_temp_7"

vaibhave postgres <postgresvaibhave@gmail.com>

View thread
From: vaibhave postgres <postgresvaibhave@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Noah Misch <noah@leadboat.com>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
Date: 2024-09-21T06:12:19Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. vacuumdb: Schema-qualify operator in catalog query's WHERE clause.

  2. reindexdb: Skip reindexing temporary tables and indexes.

  3. vacuumdb: Skip temporary tables in query to build list of relations

  4. Use catalog query to discover tables to process in vacuumdb

Thanks for the review and feedback.

On Sat, Sep 21, 2024 at 11:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> > It looks like reindexdb has the same issue. It would be good to
> > update reindexdb to skip temp tables as well to fix this.
>
> Agreed.
>
> > For the proposed patch, it seems better to use
> CppAsString2(RELPERSISTENCE_TEMP)
> > instead of 't'.
>
> +1, if we can easily avoid hard-coding that value we should do so.
> It's not that we're going to change the value; it's that it makes
> it way easier to grep the source tree for relevant code.
>
>                         regards, tom lane
>