Re: Patch: dumping tables data in multiple chunks in pg_dump

Hannu Krosing <hannuk@google.com>

From: Hannu Krosing <hannuk@google.com>

To: Zsolt Parragi <zsolt.parragi@percona.com>

Cc: David Rowley <dgrowleyml@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>

Date: 2026-01-19T23:07:56Z

Lists: pgsql-hackers

Attachments

v8-0001-changed-flag-name-to-max-table-segment-pages.patch (application/x-patch) patch v8-0001

Thanks Zsolt

I changed it to use the configured BLCKSZ in attached patch.

But you may be right that current_setting('block_size')::int is the
better way to go as we are interested in the page size at the target
database, not what the pg_sump was compiled with

I'll wait for other feedback as well and then send the next patc with changes




On Mon, Jan 19, 2026 at 10:15 PM Zsolt Parragi
<zsolt.parragi@percona.com> wrote:
>
> Hello
>
> pgdump.c:7174
>
> + appendPQExpBufferStr(query, "pg_relation_size(c.tableoid)/8192 AS
> relpages, ");
>
> Shouldn't this be something like
>
> + appendPQExpBufferStr(query,
> "pg_relation_size(c.oid)/current_setting('block_size')::int AS
> relpages, ");
>
> instead?