Horton

Re: DROP OWNED BY fails to clean out pg_init_privs grants

Hannu Krosing <hannuk@google.com>

View thread View on postgr.es
From: Hannu Krosing <hannuk@google.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Robert Haas <robertmhaas@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Noah Misch <nmisch@google.com>
Date: 2024-06-20T17:43:06Z
Lists: pgsql-hackers 
Or perhaps we should still also patch pg_dump to ignore the aclentries
which refer to roles that do not exist in the database ?

On Thu, Jun 20, 2024 at 7:41 PM Hannu Krosing <hannuk@google.com> wrote:
>
> Then maybe we should put a query / function in the release notes to
> clean up the existing mess.
>
> Thinking of it we should do it anyway, as the patch only prevents new
> messiness from happening and does not fix existing issues.
>
> I could share a query to update the pg_init_privs with non-existent
> role to replace it with the owner of the object if we figure out a
> correct place to publish it.
>
> ---
> Hannu
>
>
>
>
> On Thu, Jun 20, 2024 at 5:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Hannu Krosing <hannuk@google.com> writes:
> > > Is there anything that could be back-patched with reasonable effort ?
> >
> > Afraid not.  The whole thing is dependent on pg_shdepend entries
> > that won't exist in older branches.
> >
> >                         regards, tom lane

Commits

  1. Allow meson builds to run test_pg_dump test in installcheck mode.

  2. Remove recordExtensionInitPriv[Worker]'s ownerId argument.

  3. Improve tracking of role dependencies of pg_init_privs entries.

  4. Fix failure to track role dependencies of pg_init_privs entries.

  5. Drop global objects after completed test