Re: DROP OWNED BY fails to clean out pg_init_privs grants
Hannu Krosing <hannuk@google.com>
From: Hannu Krosing <hannuk@google.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Robert Haas <robertmhaas@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Noah Misch <nmisch@google.com>
Date: 2024-06-20T19:42:56Z
Lists: pgsql-hackers
It does happen with some regularity. At least one large cloud database provider I know of saw this more than once a month until the mitigations were integrated in the major version upgrade process. It is possible that making database upgrades easier via better automation is what made this turn up more, as now less experienced / non-DBA types are more comfortable doing the version upgrades, whereas before it would be something done by a person who can also diagnose it and manually fix pg_init_privs. Still it would be nice to have some public support for users of non-managed PostgreSQL databases as well On Thu, Jun 20, 2024 at 8:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Hannu Krosing <hannuk@google.com> writes: > > Or perhaps we should still also patch pg_dump to ignore the aclentries > > which refer to roles that do not exist in the database ? > > I didn't want to do that before, and I still don't. Given that this > issue has existed since pg_init_privs was invented (9.6) without > prior reports, I don't think it's a big enough problem in practice > to be worth taking extraordinary actions for. > > regards, tom lane
Commits
-
Allow meson builds to run test_pg_dump test in installcheck mode.
- f663f4daf075 16.5 landed
- b0c5b215dace 17.0 landed
-
Remove recordExtensionInitPriv[Worker]'s ownerId argument.
- ba26d156636c 17.0 landed
-
Improve tracking of role dependencies of pg_init_privs entries.
- 35dd40d34cbd 17.0 landed
-
Fix failure to track role dependencies of pg_init_privs entries.
- 534287403914 17.0 landed
-
Drop global objects after completed test
- 936e3fa3787a 17.0 cited