Re: Psql meta-command conninfo+

Hunaid Sohail <hunaidpgml@gmail.com>

From: Hunaid Sohail <hunaidpgml@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Maiquel Grassi <grassi@hotmail.com.br>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Jim Jones <jim.jones@uni-muenster.de>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Nathan Bossart <nathandbossart@gmail.com>, "Imseih (AWS), Sami" <simseih@amazon.com>, Peter Eisentraut <peter@eisentraut.org>, Pavel Luzanov <p.luzanov@postgrespro.ru>, Erik Wienhold <ewie@ewie.name>, "David G. Johnston" <david.g.johnston@gmail.com>
Date: 2025-01-07T09:43:48Z
Lists: pgsql-hackers
Hi,

Thank you for your valuable feedback.

1/ I am having a hard time making sense of the section "Current Status"
> None of the values in that section can be changed in the lifetime
> of a connection. The description "Current Status" makes it
> seem like they can change.
>

Any suggestions?

2/ Can't this be simplified to:
>
> "Connection Information": attributes that cannot be changed
> during the life of a connection.


I will update the docs.
Since both "Current Status" and "Connection Information" contain attributes
that cannot be changed in the lifetime of a connection, they can be merged.
Any feedback?


> I think "Connection Encryption" seems unnecessary here as
> well and it could be added to "Connection Information".


Yes, we can do that, but we’d be left with two tables:
"Connection Information" and "Server Parameter Settings". Does that work?

"Server Parameter Settings": This section should include
> all under [1]. For example, "in_hot_standby" is very
> useful, and so is "application_name". Why are they
> not included?
>

There was a discussion about "application_name" earlier in the thread, and
it was removed by the original author.
However, since we now have a separate table, it makes sense to include all
parameters.

3/ I think that if we are showing "Session Authorization",
> we should also show "Role Name", since either one of those
> values changing can result in a different "Superuser" value.
> In the example below, the user may be confused in thinking
> that "postgres" is not a superuser. Showing the role name
> will make the picture clearer. What do you think?
>

Agreed. However, since we're using the libpq API, I don't think we can
retrieve the role name.
Maybe remove "Session Authorization" instead?

Regards,
Hunaid Sohail

Commits

  1. psql: Change new \conninfo to use SSL instead of TLS

  2. Change \conninfo to use tabular format

  3. Update extension lookup routines to use the syscache

  4. Improve COPY TO performance when server and client encodings match

  5. doc: Remove superfluous bracket in synopsis

  6. Remove psql support for server versions preceding 9.2.