Horton

Thread

Commits

  1. doc: Improve consistency in varlistentry attributes

  1. doc: fix two id/xreflabel inconsistencies in config.sgml

    Bill Kim <billkimjh@gmail.com> — 2026-06-28T05:36:29Z

     Hi hackers,

  Attached is a tiny docs patch that fixes two SGML attribute
  inconsistencies in config.sgml.

  1. The varlistentry for enable_group_by_reordering has
     id="guc-enable-groupby-reordering" — every other enable_*
     parameter in the file uses the guc-enable-X-y-z form that
     mirrors the underscores in the GUC name. Renaming to
     guc-enable-group-by-reordering matches that convention.

  2. The varlistentry for quote_all_identifiers has
     xreflabel="quote-all-identifiers" with hyphens — every other
     xreflabel in the file matches the GUC name verbatim with
     underscores. Fixing to xreflabel="quote_all_identifiers".

  Neither id has any incoming linkend reference, so this is purely a
  consistency change with no callsite churn.

  I used an LLM (Claude Code) as part of preparing this — it spotted
  the inconsistencies during a sweep of config.sgml. I reviewed the
  diff myself before sending.

  Regards,
  Bill Kim

  2. Re: doc: fix two id/xreflabel inconsistencies in config.sgml

    Peter Smith <smithpb2250@gmail.com> — 2026-06-28T19:53:23Z

    On Sun, Jun 28, 2026 at 9:29 PM Bill Kim <billkimjh@gmail.com> wrote:
>
>  Hi hackers,
>
>   Attached is a tiny docs patch that fixes two SGML attribute
>   inconsistencies in config.sgml.
>
>   1. The varlistentry for enable_group_by_reordering has
>      id="guc-enable-groupby-reordering" — every other enable_*
>      parameter in the file uses the guc-enable-X-y-z form that
>      mirrors the underscores in the GUC name. Renaming to
>      guc-enable-group-by-reordering matches that convention.
>
>   2. The varlistentry for quote_all_identifiers has
>      xreflabel="quote-all-identifiers" with hyphens — every other
>      xreflabel in the file matches the GUC name verbatim with
>      underscores. Fixing to xreflabel="quote_all_identifiers".
>
>   Neither id has any incoming linkend reference, so this is purely a
>   consistency change with no callsite churn.
>

The changes sound good to me, but I did not see any attachment.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

  3. Re: doc: fix two id/xreflabel inconsistencies in config.sgml

    Daniel Gustafsson <daniel@yesql.se> — 2026-06-28T22:05:48Z

    > On 28 Jun 2026, at 21:53, Peter Smith <smithpb2250@gmail.com> wrote:

> The changes sound good to me,

Agreed.

> but I did not see any attachment.

No need to send in, I've pushed these changes.

--
Daniel Gustafsson

  4. Re: doc: fix two id/xreflabel inconsistencies in config.sgml

    Bill Kim <billkimjh@gmail.com> — 2026-06-29T12:08:19Z

    Thanks!

2026년 6월 29일 (월) 오전 7:06, Daniel Gustafsson <daniel@yesql.se>님이 작성:

> > On 28 Jun 2026, at 21:53, Peter Smith <smithpb2250@gmail.com> wrote:
>
> > The changes sound good to me,
>
> Agreed.
>
> > but I did not see any attachment.
>
> No need to send in, I've pushed these changes.
>
> --
> Daniel Gustafsson
>
>