Re: [Patch] add new parameter to pg_replication_origin_session_setup
Doruk Yilmaz <doruk@mixrank.com>
From: Doruk Yilmaz <doruk@mixrank.com>
To: Amit Kapila <amit.kapila16@gmail.com>, Euler Taveira <euler@eulerto.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-07-28T21:13:27Z
Lists: pgsql-hackers
On Mon, Mar 3, 2025 at 6:39 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > To use replication_origin by multiple processes, one must maintain the > commit order as we do internally by allowing the leader process to > wait for the parallel worker to finish the commit. See comments atop > replorigin_session_setup(). Now, we could expose the pid parameter as > proposed by the patch after documenting the additional requirements, > but I am afraid that users may directly start using the API without > following the commit order principle, which can lead to incorrect > replication. So, isn't it better to do something to avoid the misuse > of this feature before exposing it? Wouldn't mentioning/describing needing to follow the commit order principle on the documentation be enough for this? It is quite an advanced feature that I don't believe person intending to use it won't start with reading documentation first. Is there any updates on the commit? I see that intended commitfest window ended. Thanks, Doruk Yılmaz
Commits
-
Refactor replorigin_session_setup() for better readability.
- 735e8fe68535 19 (unreleased) landed
-
Prevent unintended dropping of active replication origins.
- e385a4e2fd8e 19 (unreleased) landed
-
Add optional pid parameter to pg_replication_origin_session_setup().
- 5b148706c5c8 19 (unreleased) landed