Horton

Re: [PATCH] Add `headerscheck` run_target to meson

Miłosz Bieniek <bieniek.milosz0@gmail.com>

View thread View on postgr.es
From: Miłosz Bieniek <bieniek.milosz0@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-11-28T12:58:01Z
Lists: pgsql-hackers

Attachments

pt., 28 lis 2025 o 12:53 Peter Eisentraut <peter@eisentraut.org> napisał(a):
>
> On 27.11.25 10:28, Miłosz Bieniek wrote:
> > While reviewing a patch I noticed that we have a `make -s headerscheck`
> > but there is no equivalent in meson.
> > I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
> > targets.
>
> This would be good to have, but I don't think your patch works.  It
> seems you need to add the srcdir and builddir command-line arguments to
> the invocations.
>

I think you are right. I added srcdir and builddir arguments.

Commits

  1. headerscheck: Get CXXFLAGS from Makefile.global

  2. meson: Add headerscheck and cpluspluscheck targets

  3. meson: Add {perl|python}_includespec to generated Makefile.global