Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding

Nikhil Sontakke <nikhils@2ndquadrant.com>

From: Nikhil Sontakke <nikhils@2ndquadrant.com>

To: Heikki Linnakangas <hlinnaka@iki.fi>

Cc: Michael Paquier <michael@paquier.xyz>, Simon Riggs <simon@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2018-06-14T11:02:06Z

Lists: pgsql-hackers

Attachments

gid_length.patch (application/octet-stream) patch

Hi Heikki,


>
> Pushed, thanks for the review!
>

There was a slight oversight in the twophase_gid length calculation in
the XactLogCommitRecord() code path in the cf5a1890592 commit. The
corresponding XactLogAbortRecord() code path was ok. PFA, a small
patch to fix the oversight.

Regards,
Nikhils
-- 
 Nikhil Sontakke                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

Fix off-by-one bug in XactLogCommitRecord
- ff03112bdc70 11.0 landed
Fix confusion on the padding of GIDs in on commit and abort records.
- cf5a1890592b 11.0 landed
Store 2PC GID in commit/abort WAL recs for logical decoding
- 1eb6d6527aae 11.0 cited