Horton

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

Nikhil Sontakke <nikhils@2ndquadrant.com>

View thread View on postgr.es
From: Nikhil Sontakke <nikhils@2ndquadrant.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: vaishnaviprabakaran@gmail.com, Craig Ringer <craig@2ndquadrant.com>, daniel@manitou-mail.org, horiguchi.kyotaro@lab.ntt.co.jp, Michael Paquier <michael.paquier@gmail.com>, daniel@yesql.se, Andres Freund <andres@anarazel.de>, David Steele <david@pgmasters.net>, VaishnaviP@fast.au.fujitsu.com, Haribabu Kommi <kommi.haribabu@gmail.com>, tsunakawa.takay@jp.fujitsu.com, dmitigr@gmail.com, PostgreSQL-development <pgsql-hackers@postgresql.org>, m.kniep@web.de, fujita.etsuro@lab.ntt.co.jp, iwata.aya@jp.fujitsu.com, Michael Paquier <michael@paquier.xyz>
Date: 2019-08-30T13:36:34Z
Lists: pgsql-hackers

Attachments

Hi,

> > This patch has been around for some time now, the last version fails to
> > apply cleanly and in-depth reviews have happened.  I am moving that to
> > the next CF, waiting on its author.
>
> Unfortunately, nothing was changed since then, so there is already some amount
> of unaddressed review feedback. I'll move this patch to "Returned with
> feedback".
>

Craig Ringer mentioned about this thread to me recently.

This effort has seen decent reviews from Craig, Andres and Michael
already. So, I thought of refreshing it to work against latest master
HEAD.

PFA, main patch as well as the test patch (I named the test patch v17
to be consistent with the main patch). The major grouse with the test
patch AFAICS was the use of non-Windows compliant timersub() function.
I have now used INSTR_TIME_SET_CURRENT/INSTR_TIME_SUBTRACT family of
portable macros for the same.

Please let me know on what we think of the above.

Regards,
Nikhil
-- 
Nikhil Sontakke
2ndQuadrant - PostgreSQL Solutions for the Enterprise
https://www.2ndQuadrant.com/

Commits

  1. Add libpq pipeline mode support to pgbench

  2. Implement pipeline mode in libpq