Re: Regression tests fail with tzdata 2024b

Sven Klemm <sven@timescale.com>

From: Sven Klemm <sven@timescale.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Wolfgang Walther <walther@technowledgy.de>, pgsql-hackers@lists.postgresql.org

Date: 2024-09-18T06:04:03Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Run regression tests with timezone America/Los_Angeles.
- b28b9b19bbe3 13.17 landed
- b27622c90869 14.14 landed
- 2b94ee58bf25 15.9 landed
- 2abc88958039 16.5 landed
- 205813da4c26 12.21 landed
- b8ea0f675f35 18.0 landed
- 6283ff2018e3 17.0 landed
Don't require bleeding-edge timezone data in timestamptz regression test.
- 8d7af8fbe734 9.5.0 cited

On Tue, Sep 17, 2024 at 4:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Wolfgang Walther <walther@technowledgy.de> writes:
> > The core regression tests need to be run with a timezone that tests
> > special cases in the timezone handling code. But that might not be true
> > for extensions - all they want could be a stable output across major and
> > minor versions of postgres and versions of tzdata. It could be helpful
> > to set pg_regress' timezone to UTC, for example?
>
> I would not recommend that choice.  It would mask simple errors such
> as failing to apply the correct conversion between timestamptz and
> timestamp values.  Also, if you have test cases that are affected by
> this issue at all, you probably have a need/desire to test things like
> DST transitions.
>

As far as I'm aware timescaledb does not rely on specifics of tzdata
version but just needs a stable setting for timezone. I guess I'll adjust
our tests to not depend on upstream pg_regress timezone.

-- 
Regards, Sven Klemm