Re: Add --system-identifier / -s option to pg_resetwal

Nikolay Samokhvalov <nik@postgres.ai>

From: Nikolay Samokhvalov <nik@postgres.ai>

To: Michael Paquier <michael@paquier.xyz>

Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>, Andrey Borodin <amborodin@acm.org>, Kirk Wolak <wolakk@gmail.com>

Date: 2025-06-04T18:46:21Z

Lists: pgsql-hackers

Attachments

0002-pg_resetwal--system-identifier.patch (application/octet-stream)

Thank you, Peter and Michael, for the reviews

Attached is v2, simplified as suggested:
- Removed short option -s
- Removed interactive confirmation and --force
- Simplified tests leaving only essential ones

Additionally, there was an off-list review done by Andrey Borodin, so his
comments also addressed:
- Simplified logic, getting rid of '-' check (negative numbers) -- decided
to accept negative input values (they wrap to valid positive uint64)

Nik