Horton

Re: nodes/*funcs.c inconsistencies

Peter Geoghegan <pg@heroku.com>

View thread
From: Peter Geoghegan <pg@heroku.com>
To: Noah Misch <noah@leadboat.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Stephen Frost <sfrost@snowman.net>
Date: 2015-08-02T22:07:34Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add support for renaming domain constraints

On Sun, Aug 2, 2015 at 1:28 PM, Noah Misch <noah@leadboat.com> wrote:
> A fresh audit found the attached problems new in 9.5[1].  Most are cosmetic
> INT/UINT or field order corrections.

I was responsible for a couple of the cosmetic ones. Sorry about that.

It occurs to me that we could do a little more to prevent this
automatically. Couldn't we adopt
AssertVariableIsOfType()/AssertVariableIsOfTypeMacro() to macros like
READ_UINT_FIELD()?

I'm surprised that this stuff was only ever used for logical decoding
infrastructure so far.
-- 
Peter Geoghegan